Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to workaround venv failure in Actions runner 20240929.1. #950

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Attempt to workaround venv failure in Actions runner 20240929.1. #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ddffbb
Attempt to workaround venv failure in Actions runner 20240929.1.
MarkCallow Oct 4, 2024
e00db28
Only run venv setup if Python enabled.
MarkCallow Oct 4, 2024
4cf0528
Try installing virtualenv.
MarkCallow Oct 4, 2024
83785e0
Try running venv activate and passing PATH in GITHUB_ENV.
MarkCallow Oct 7, 2024
cce2b1b
Try pip instead of pipx.
MarkCallow Oct 8, 2024
0646127
Add explanatory comments.
MarkCallow Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,16 @@ jobs:
with:
python-version: '3.11.4'

# virtualenv is no longer included as of 20240929.1 runner so
# install it ourselves. See
# https://github.com/actions/runner-images/issues/10749.
#
# Note that it is the builds of sdist and wheel that require virtualenv
# not the explicit dependencies of pyktx.
- name: Install Python virtualenv
if: matrix.options.py == 'ON' && matrix.check_mkvk != 'ONLY'
run: pip install virtualenv

- name: Init CTS submodule
if: matrix.options.tools_cts =='ON'
run:
Expand Down
3 changes: 3 additions & 0 deletions interface/python_binding/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ add_custom_command(
LIBKTX_INCLUDE_DIR=${CMAKE_SOURCE_DIR}/include
LIBKTX_LIB_DIR=${LIBKTX_LIB_DIR}
LIBKTX_VERSION=${KTX_VERSION_NORMALIZED}
# Bulding sdist requires a virtual env. I have not found a
# a way via find_package to ensure venv support is installed.
${PYTHON_EXECUTABLE} -m build --sdist --outdir ${DIST_DIR}
WORKING_DIRECTORY
${SOURCE_DIR}
Expand All @@ -103,6 +105,7 @@ add_custom_command(
LIBKTX_INCLUDE_DIR=${CMAKE_SOURCE_DIR}/include
LIBKTX_LIB_DIR=${LIBKTX_LIB_DIR}
LIBKTX_VERSION=${KTX_VERSION_NORMALIZED}
# Ditto with sdist venv comment.
${PYTHON_EXECUTABLE} -m build --wheel --outdir ${DIST_DIR}
WORKING_DIRECTORY
${SOURCE_DIR}
Expand Down
Loading