Fix occasional GPU crash when a smaller descriptor set replaces a larger one. #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger one.
If a descriptor set with fewer than 64 descriptors replaced one with more,
the resources it contained were not made resident to the GPU, due to
MVKBitArray thrashing incorrectly when transitioning between static and
dynamic memory allocations.
- Overhaul MVKBitArray design:
- Never downsize memory allocation unless reset() is called.
- No longer support static allocation for smaller sizes, to avoid thrashing
between dynamic and static allocs when frequently resizing up and down.
- Use realloc() instead of malloc/copy to improve performance.
- Simplify tracking of partially and fully disabled sections.
- Rename setXX() and clearXX() functions to enableXX() & disableXX().
- Rename several internal functions.
- getIndexOfFirstEnabledBit() & enumerateEnabledBits()
no longer have an option to disable the bit.
- MVKDescriptorPool track highest descriptor set allocated,
instead of querying MVKBitArray.
This was referenced Sep 27, 2024
Open
cdavis5e
approved these changes
Sep 27, 2024
|
Unfortunately it seems that this PR introduced a regression in I could capture this stack trace at the crash I don't know whether this is useful. Tomorrow I can try to reduce the crashing program to a pure Vulkan MWE. |
|
Ok, I debugged it directly and submitted #2381 to fix this. |
Thanks for your debugging effort, and for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a descriptor set with fewer than 64 descriptors replaced one with more, the resources it contained were not made resident to the GPU, due to
MVKBitArraythrashing incorrectly when transitioning between static and dynamic memory allocations.MVKBitArraydesign:reset()is called.realloc()instead of malloc/copy to improve performance.setXX()andclearXX()functions toenableXX()&disableXX().getIndexOfFirstEnabledBit()&enumerateEnabledBits()no longer have an option to disable the bit.MVKDescriptorPooltrack highest descriptor set allocated, instead of queryingMVKBitArray.Fixes part of issue #2271.