Create deb package #233
Closed
Create deb package #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beanavil
force-pushed
the
58-create-deb-package
branch
from
06d47f1
to
bc4615e
Compare
Beanavil
force-pushed
the
58-create-deb-package
branch
6 times, most recently
from
04c30c8
to
b2b5a15
Compare
…e and installation prefix fixed
Beanavil
force-pushed
the
58-create-deb-package
branch
from
b2b5a15
to
f5893a8
Compare
bashbaug
reviewed
Aug 1, 2023
There was a problem hiding this comment.
I'm not sure how to test these changes and I'm not a packaging expert, but this all looks reasonable to me. I think the odds of breaking any existing functionality is low, therefore we should merge this sooner rather than later and we will perhaps get more feedback.
| "https://github.com/KhronosGroup/OpenCL-Headers") | ||
|
|
||
| # Version number [epoch:]upstream_version[-debian_revision] | ||
| set(LATEST_RELEASE_VERSION "2023.04.17") |
There was a problem hiding this comment.
Out of curiosity where did this date come from? Will it need to be updated manually? If so, when should it be updated?
| # non-native pkg) | ||
| set(PACKAGE_VERSION_REVISION "${CPACK_DEBIAN_PACKAGE_VERSION}-${CPACK_DEBIAN_PACKAGE_RELEASE}") | ||
|
|
||
| set(DEBIAN_PACKAGE_NAME "opencl-c-headers") |
There was a problem hiding this comment.
Is this an existing package name or something new? If this is a new package name I'd suggest removing "c", since I tend to think of "OpenCL C" as being the kernel language.
|
Closing this, as the functionality was added in #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CMake module with the packaging configuration and "Package" and "Consume" steps to GitHub actions to check that it works as it should.