Fix multiview synchronization #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We preserve the contents of the color attachment between subpasses, so need to make the image visible for read as well.
Previously the only barrier between subpasses was for the color attachment.
The VK_ACCESS_INPUT_ATTACHMENT_READ was incorrect because even in the tests that use input attachments, the input attachment is a separate image from the color attachment. The actual hazard we need to protect against is reads/writes to the color and ZS attachments.
Depth writes happen in LATE_FRAGMENT_TESTS, not EARLY_FRAGMENT_TESTS.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.