Allow normalization in gather_attribute_change user extension #1955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to mark data as normalized from a user extension like https://github.com/julienduroure/gltf-hooks-examples/blob/main/gltf_attribute_change.py
The motivation being, that one might want to transform a
Float
attribute into aUnsignedByte
color attribute that requires the"normalized":true
tag in the glTF 2.0 accessor to be valid.The only change is exposing the normalization boolean and allowing it to be set in a user extension like