-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(cmd): use resty.signal for process signaling (#11382)
* refactor(cmd): rename kong.cmd.utils.kill => kong.cmd.utils.process There's a large refactor of this module in the pipeline, and renaming from 'kill' to 'process' makes the API more sensible. * refactor(cmd): rename process.is_running => process.exists This is another name-only change ahead of some larger refactoring of the kong.cmd.utils.process module. * refactor(cmd): use resty.signal for process signaling This refactors kong.cmd.utils.process to use the resty.signal library for sending signals instead of dropping to a shell. This comes with improvements (albeit minor) to performance and security. * chore(cmd): remove redundant process check * tests(helpers): fix flaky http_mock PID file test * chore(cmd): return error on signal sending failures
- Loading branch information
Showing
14 changed files
with
727 additions
and
134 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
bbdda0b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bazel Build
Docker image available
kong/kong:bbdda0b0f668c5dbbbebe8af3a92f445c92776c4
Artifacts available https://github.com/Kong/kong/actions/runs/6247316667