Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cmd): use resty.signal for process signaling #11382

Merged
merged 6 commits into from
Sep 20, 2023
Merged

refactor(cmd): use resty.signal for process signaling #11382

merged 6 commits into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. refactor(cmd): rename kong.cmd.utils.kill => kong.cmd.utils.process 

    There's a large refactor of this module in the pipeline, and renaming
from 'kill' to 'process' makes the API more sensible.
    @flrgh @hanshuebner
    flrgh authored and hanshuebner committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ea0dd26 View commit details
    Browse the repository at this point in the history

  2. refactor(cmd): rename process.is_running => process.exists 

    This is another name-only change ahead of some larger refactoring of the
kong.cmd.utils.process module.
    @flrgh @hanshuebner
    flrgh authored and hanshuebner committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f50d9a4 View commit details
    Browse the repository at this point in the history

  3. refactor(cmd): use resty.signal for process signaling 

    This refactors kong.cmd.utils.process to use the resty.signal library
for sending signals instead of dropping to a shell.

This comes with improvements (albeit minor) to performance and security.
    @flrgh @hanshuebner
    flrgh authored and hanshuebner committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    972030c View commit details
    Browse the repository at this point in the history

  4. chore(cmd): remove redundant process check

    @flrgh @hanshuebner
    flrgh authored and hanshuebner committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bd3d428 View commit details
    Browse the repository at this point in the history

  5. tests(helpers): fix flaky http_mock PID file test

    @flrgh @hanshuebner
    flrgh authored and hanshuebner committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1c6f3a0 View commit details
    Browse the repository at this point in the history

  6. chore(cmd): return error on signal sending failures

    @flrgh @hanshuebner
    flrgh authored and hanshuebner committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2d268ad View commit details
    Browse the repository at this point in the history