Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor(cmd): use resty.signal for process signaling" #11620

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Revert "refactor(cmd): use resty.signal for process signaling" #11620

merged 1 commit into from
Sep 20, 2023

Conversation

hanshuebner
Copy link
Contributor

Reverts #11382 to re-do without squashing

@hanshuebner hanshuebner mentioned this pull request Sep 20, 2023
Draft
@hanshuebner hanshuebner assigned flrgh and unassigned hanshuebner Sep 20, 2023
@flrgh
Copy link
Contributor

flrgh commented Sep 20, 2023

For posterity's sake, there are actually two reasons for us to merge this:

  1. commit history cleanup (as noted in the PR desc)
  2. we discovered a subtle bug in the way that resty.signal traverses LUA_CPATH in order to discover and load its shared object dependency (link) and need to revert this to un-break master

We'll need to resolve item 2 before merging the follow-up #11621.

@flrgh flrgh merged commit bfc8ef7 into master Sep 20, 2023
31 of 33 checks passed
@flrgh flrgh deleted the revert-11382-refactor/cmd-utils-process branch September 20, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flrgh flrgh flrgh approved these changes

Assignees

@flrgh flrgh

Labels
core/cli size/XL skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanshuebner @flrgh