chore(ci): cleanup kong before running test suite (a spec file) #12567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
ci/clean-prefix
branch
3 times, most recently
from
d134cee
to
b39ef16
Compare
bungle
force-pushed
the
ci/clean-prefix
branch
2 times, most recently
from
8f99845
to
9a2ed78
Compare
bungle
changed the title
bungle
force-pushed
the
ci/clean-prefix
branch
from
9a2ed78
to
2ba6996
Compare
bungle
changed the title
bungle
force-pushed
the
ci/clean-prefix
branch
from
2ba6996
to
5835178
Compare
samugi
reviewed
Feb 15, 2024
bungle
force-pushed
the
ci/clean-prefix
branch
2 times, most recently
from
7e92cbd
to
9c89854
Compare
3 tasks
bungle
force-pushed
the
ci/clean-prefix
branch
2 times, most recently
from
9ee6959
to
20b47ac
Compare
bungle
added
the
cherry-pick kong-ee
### Summary Cleanup Kong before running the test suite (a spec file). Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
Water-Melon
reviewed
Mar 6, 2024
| local cjson = require 'cjson' | ||
| local socket_unix = require 'socket.unix' | ||
| local function cleanup() | ||
| local prefix = assert(require("kong.conf_loader")(os.getenv("KONG_SPEC_TEST_CONF_PATH") or "spec/kong_tests.conf")).prefix |
There was a problem hiding this comment.
It seems that only one prefix directory is being deleted here. However, if there are tests like spec-ee/02-integration/03-vitals/08-hybrid_spec.lua that create multiple prefix paths, how can we clear all of them?
|
PR review discussion: Have already implemented other solutions, close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup Kong before running the test suite (a spec file).
KAG-3735