Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devcontainer): add curl to dependencies #12594

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

poelzi
Copy link
Contributor

@poelzi poelzi commented Feb 21, 2024

Summary

Later stages of the dependency setup require curl.
Fixes devcontainer bootstrapping

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

Later stages of the dependency setup require curl
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Feb 21, 2024
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Feb 21, 2024
Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use the devcontainer, but adding curl looks sensible to me.

@poelzi
Copy link
Contributor Author

poelzi commented Feb 21, 2024

I'm pretty sure nobody uses devcontainers seriously since the "make test" does not really work. But since you are not providing a flake.nix getting a dev environment running is just pain I'm not willing to do for some fixes ;) ....

@gszr
Copy link
Member

gszr commented Feb 23, 2024

I'm pretty sure nobody uses devcontainers seriously since the "make test" does not really work. But since you are not providing a flake.nix getting a dev environment running is just pain I'm not willing to do for some fixes ;) ....

@poelzi What specific challenges did you face? For me, this works fine:

make clean
make dev
make test 

Perhaps you didn't set the GITHUB_TOKEN env var? (No special permissions needed - it's a limitation of the gh CLI that doesn't allow downloads from public repos without a token set)

@bungle bungle added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 19, 2024
@hanshuebner hanshuebner merged commit e368047 into Kong:master Mar 19, 2024
25 checks passed
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@locao locao changed the title Fix devcontainer dependencies. fix(devcontainer): add curl to dependencies Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants