fix(mlcache): release lock upon exiting the renew function #12743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
chronolaw
approved these changes
Mar 18, 2024
chobits
force-pushed
the
fix_mlcache_renew_unlock
branch
from
e43dcdf
to
1e62c20
Compare
ADD-SP
reviewed
Mar 18, 2024
chobits
force-pushed
the
fix_mlcache_renew_unlock
branch
from
9eea71f
to
60cecef
Compare
chronolaw
approved these changes
Mar 18, 2024
chobits
force-pushed
the
fix_mlcache_renew_unlock
branch
from
60cecef
to
39c13d5
Compare
chobits
commented
Mar 21, 2024
Co-authored-by: Qi <add_sp@outlook.com>
chobits
force-pushed
the
fix_mlcache_renew_unlock
branch
from
57f4d02
to
f8e8962
Compare
bungle
approved these changes
Mar 21, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the
mlcache:renewfunction would return an error message without releasing the lock, potentially leading to lock leaks. With this change, the function now releases the lock before returning the error message, ensuring proper cleanup and preventing lock leaks.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]no open issue, it's discovered by reviewing the source code.