Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(template): eliminate manual indexing on certain Nginx variables due to inherent default indexing #12755

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Mar 19, 2024

Summary

The following ngx vars were added by #11722 for performance:

lua_kong_load_var_index $http_x_kong_request_debug;
lua_kong_load_var_index $http_x_kong_request_debug_token;
lua_kong_load_var_index $http_x_kong_request_debug_log;

And the lua-kong-nginx-module index these by default now: https://github.com/Kong/lua-kong-nginx-module/releases/tag/0.9.0, and we have already bumped it by #12752, so we can remove these explicit indexing now.

Checklist

  • [N/A] The Pull Request has tests
  • [N/A] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

N/A

… are already indexed by default

The following ngx vars has already been indexed by default in #12752:

* $http_x_kong_request_debug
* $http_x_kong_request_debug_token
* $http_x_kong_request_debug_log
@github-actions github-actions bot added core/templates cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 19, 2024
@ADD-SP ADD-SP marked this pull request as ready for review March 19, 2024 02:55
@ADD-SP ADD-SP changed the title refactor(template): remove explicit indexing of some ngx vars as they are already indexed by default refactor(template): eliminate manual indexing on certain Nginx variables due to inherent default indexing Mar 19, 2024
@ADD-SP ADD-SP merged commit 1da0a40 into master Mar 19, 2024
43 of 45 checks passed
@ADD-SP ADD-SP deleted the add_sp/refactor-remove-3-indexed-var branch March 19, 2024 05:54
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/templates size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants