feat(balancer): record the cache flag of each connection which used during balancer retry #12760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring balancer retry enhanced the functionality of the load balancer to record the cache flag of each connection attempt. this provides better visibility into whether a connection was reused from the upstream connection pool. Fix: (FTI-5616)[https://konghq.atlassian.net/browse/FTI-5616] Signed-off-by: tzssangglass <tzssangglass@gmail.com>
github-actions
bot
added
the
cherry-pick kong-ee
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
chobits
reviewed
Mar 21, 2024
| @@ -1278,6 +1278,10 @@ function Kong.balancer() | |||
| -- record failure data | |||
| local previous_try = tries[try_count - 1] | |||
| previous_try.state, previous_try.code = get_last_failure() | |||
| if ngx.config.subsystem == "http" then | |||
| local peer_conn = require "resty.kong.peer_conn" | |||
There was a problem hiding this comment.
Do we have any reason to require this library in runtime code path?
There was a problem hiding this comment.
require at the top of the file will cause it to fail when running it in the stream.
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
|
wait for Kong/lua-kong-nginx-module#85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
enhanced the functionality of the load balancer to record the cache flag of each connection attempt. this provides better visibility into whether a connection was reused from the upstream connection pool.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix: (FTI-5616)[https://konghq.atlassian.net/browse/FTI-5616]