Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router/atc): remove closure to avoid NYIs #12788

Merged
merged 2 commits into from
Mar 28, 2024
Merged

refactor(router/atc): remove closure to avoid NYIs #12788

merged 2 commits into from
Mar 28, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Mar 27, 2024 •
edited
Loading

Summary

Closure may cause unnecessary NYIs, removing them will improve performance.

KAG-4138

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/router cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 27, 2024
@chronolaw chronolaw requested a review from ADD-SP March 28, 2024 01:26
@chronolaw chronolaw requested a review from chobits March 28, 2024 01:31
@ADD-SP ADD-SP merged commit 821af9d into master Mar 28, 2024
28 checks passed
@ADD-SP ADD-SP deleted the refactor/remove_nyis_in_transform branch March 28, 2024 01:57
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@chronolaw chronolaw removed the request for review from chobits March 28, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyZhang0707 AndyZhang0707 AndyZhang0707 approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/router size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @AndyZhang0707 @ADD-SP