Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(plugins/basic-auth): correct realm field description #12793

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

nowNick
Copy link
Contributor

@nowNick nowNick commented Mar 27, 2024

Summary

During the review of: #11794 (see comment: #11794 (review)) it was pointed out that the description for realm field was misleading. This PR corrects basic-auth description.

Checklist

  • N/A - The Pull Request has tests
  • N/A - A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • N/A - There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-3635

@github-actions github-actions bot added plugins/basic-auth schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 27, 2024
@nowNick nowNick marked this pull request as ready for review March 28, 2024 08:15
@chronolaw chronolaw changed the title feat(basic-auth): fix realm field description style(plugins/basic-auth): fix realm field description Mar 28, 2024
@chronolaw chronolaw changed the title style(plugins/basic-auth): fix realm field description style(plugins/basic-auth): correct realm field description Mar 28, 2024
@samugi samugi merged commit 8520514 into master Mar 28, 2024
43 of 45 checks passed
@samugi samugi deleted the fix/basic-auth-realm-description-fix branch March 28, 2024 08:58
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants