fix(plugins): compatibility with older data planes #12794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
samugi
force-pushed
the
fix/propagation-hybrid-compat
branch
from
5dc4c12
to
e8afc7c
Compare
ADD-SP
requested changes
Mar 28, 2024
added compatibility with older data planes for the new tracing headers propagation configuration options
samugi
force-pushed
the
fix/propagation-hybrid-compat
branch
from
e8afc7c
to
8d8792f
Compare
StarlightIbuki
approved these changes
Mar 29, 2024
|
I wonder if the CI checker reminded us that schema changes need a corresponding change to the compatibility logic. |
we'd probably need some smart check that detects additions of required fields and fail a workflow (or similar) otherwise we would end up with noisy reminders and eventually get used to ignoring them. |
ADD-SP
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
added compatibility with older data planes for the new tracing headers propagation configuration options
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4139