Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(tools/module): improve code style for readability #12798

Merged
merged 1 commit into from
Mar 29, 2024
Merged

style(tools/module): improve code style for readability #12798

merged 1 commit into from
Mar 29, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Mar 28, 2024 •
edited
Loading

Summary

  • simplfy xpcall
  • simplify if-else

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Mar 28, 2024
@chronolaw chronolaw marked this pull request as ready for review March 28, 2024 05:46
@ADD-SP ADD-SP changed the title style(tools/module): small code style clean style(module-tools): improve code style for maintainability Mar 29, 2024
@ADD-SP ADD-SP changed the title style(module-tools): improve code style for maintainability style(module-tools): improve code style for readability Mar 29, 2024
@ADD-SP ADD-SP changed the title style(module-tools): improve code style for readability style(tools/module): improve code style for readability Mar 29, 2024
@ADD-SP ADD-SP merged commit 6f3c0da into master Mar 29, 2024
45 checks passed
@ADD-SP ADD-SP deleted the style/clean_if_module_exists branch March 29, 2024 01:27
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Water-Melon Water-Melon Water-Melon approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @Water-Melon @ADD-SP