Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport -> release/3.5.x] fix(plugins/acme): fix certificate renew failure issue #12801

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[backport -> release/3.5.x] fix(plugins/acme): fix certificate renew failure issue #12801

merged 1 commit into from
Mar 28, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.5.x, triggered by a label in #12773.

Original description

Summary

Fix ACME renewal bug.

Using client.renew_certificate directly as the callback function in ngx_timer_at causes the parameter value to not be the plugin's config.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4008
Fix #12442

@Water-Melon @github-actions
fix(plugins/acme): fix certificate renew failure issue (#12773)
1b91c76 
Using client.renew_certificate directly as the callback function in ngx_timer_at
causes the parameter value to not be the plugin's config.

KAG-4008

(cherry picked from commit ca2e67c)
@team-gateway-bot team-gateway-bot added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/acme size/S labels Mar 28, 2024
@team-gateway-bot team-gateway-bot mentioned this pull request Mar 28, 2024
Merged
3 tasks
@github-actions github-actions bot added the core/wasm Everything relevant to [proxy-]wasm label Mar 28, 2024
@ADD-SP ADD-SP merged commit b2245e6 into release/3.5.x Mar 28, 2024
34 checks passed
@ADD-SP ADD-SP deleted the backport-12773-to-release/3.5.x branch March 28, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Water-Melon Water-Melon Water-Melon approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@Water-Melon Water-Melon

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/wasm Everything relevant to [proxy-]wasm plugins/acme size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@team-gateway-bot @Water-Melon @ADD-SP