chore(plugins): improve logging when anonymous not found #12833
+55
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/jwt
plugins/oauth2
plugins/hmac-auth
plugins/key-auth
plugins/basic-auth
plugins/ldap-auth
cherry-pick kong-ee
If the anonymous consumer isn't found, then the loader doesn't return an error, just nil. This causes the function kong.client.authenticate() to throw an error which is correct but not helpful to the enduser. This fixes the error handling to properly report what is wrong. Also removed throwing errors in some handlers, and replaced it with the more proper return 500 code, to be able to run exit routines on those errors.
Tieske
force-pushed
the
fix/anonymous-not-found
branch
from
a4cca7c
to
f1eb3d2
Compare
vm-001
suggested changes
Apr 7, 2024
vm-001
changed the title
|
@vm-001 , any chance we have this PR merged? Thanks |
team-eng-enablement
added
author/community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the anonymous consumer isn't found, then the loader doesn't return an error, just nil. This causes the function kong.client.authenticate() to throw an error which is correct but not helpful to the enduser.
This fixes the error handling to properly report what is wrong. Also removed throwing errors in some handlers, and replaced it with the more proper return 500 code, to be able to run exit routines on those errors.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-5861