Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shorthand_fields): remove translate_backwards in favor of replaced_with #13604

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

nowNick
Copy link
Contributor

@nowNick nowNick commented Sep 2, 2024

Summary

We've introduced replaced_with when working on shorthand_fields when used as deprecation and making sure that incoming request do not contain mismatched data: #13565

This made translate_backwards field obsolete as replaced_with is just more robust and intuitive. This PR removes that code.

Checklist

  • N/A The Pull Request has tests
  • N/A A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • N/A There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-5298

@nowNick nowNick marked this pull request as ready for review September 2, 2024 15:01
@nowNick nowNick requested review from a team and bungle September 5, 2024 09:37
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 16, 2024
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to make this more readable, I think you get an idea from this and can work forward on it.

kong/db/schema/init.lua Outdated Show resolved Hide resolved
kong/db/schema/init.lua Outdated Show resolved Hide resolved
@nowNick nowNick force-pushed the refactor/remove-translate-backwards branch from 0127d92 to 5648799 Compare September 27, 2024 08:01
@nowNick nowNick force-pushed the refactor/remove-translate-backwards branch from 5648799 to fe67a1e Compare September 27, 2024 08:14
@nowNick nowNick requested a review from bungle September 27, 2024 09:11
@Hayk-S Hayk-S merged commit 11405e5 into master Oct 1, 2024
28 checks passed
@Hayk-S Hayk-S deleted the refactor/remove-translate-backwards branch October 1, 2024 16:03
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13604-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13604-to-master-to-upstream
git checkout -b cherry-pick-13604-to-master-to-upstream
ancref=$(git merge-base a6ccbb1af2169a9edbf4491a91ecaf5d2d7fb067 fe67a1ef4d903b4fddbbd72a93a7faa5853cdd73)
git cherry-pick -x $ancref..fe67a1ef4d903b4fddbbd72a93a7faa5853cdd73

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 1, 2024
@nowNick nowNick removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants