Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(patch): add tls.disable_http2_alpn() function needed patch for disabling HTTP/2 ALPN when tls handshake. #13709

Merged
merged 7 commits into from
Oct 21, 2024
Merged

feat(patch): add tls.disable_http2_alpn() function needed patch for disabling HTTP/2 ALPN when tls handshake. #13709

merged 7 commits into from
Oct 21, 2024

Conversation

oowl
Copy link
Member

@oowl oowl commented Sep 25, 2024 •
edited
Loading

Summary

Added tls.disable_http2_alpn() function needed patch for disabling HTTP/2 ALPN when tls handshake.
Sister PR Kong/lua-kong-nginx-module#93

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

AG-119

@github-actions github-actions bot added build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 25, 2024
@fffonion
Copy link
Contributor

need a changelog

@oowl
Copy link
Member Author

oowl commented Sep 26, 2024

Let's wait to merge Kong/lua-kong-nginx-module#93 first.

@oowl oowl changed the title feat(patch): support dynamic disable http2 alpn in ssl client hello p… feat(patch): add tls.disable_http2_alpn() function needed patch for disabling HTTP/2 ALPN when tls handshake. Sep 26, 2024
@oowl oowl mentioned this pull request Sep 29, 2024
Merged
@oowl oowl force-pushed the disable-h2-alpn-re branch 3 times, most recently from 3ae4ce9 to 4e0e15f Compare September 29, 2024 15:32
@oowl oowl mentioned this pull request Oct 8, 2024
Closed
3 tasks
@oowl oowl mentioned this pull request Oct 12, 2024
Open
3 tasks
fffonion
fffonion approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@fffonion fffonion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fffonion fffonion merged commit 6d7bf68 into master Oct 21, 2024
27 checks passed
@fffonion fffonion deleted the disable-h2-alpn-re branch October 21, 2024 08:14
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyZhang0707 AndyZhang0707 AndyZhang0707 left review comments

@fffonion fffonion fffonion approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

@bungle bungle Awaiting requested review from bungle

Assignees

@oowl oowl

Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oowl @fffonion @team-gateway-bot @AndyZhang0707 @Water-Melon