Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): support official media-type of yaml in /config endpoint #13713

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

bungle
Copy link
Member

@bungle bungle commented Sep 26, 2024

Symmary

The https://datatracker.ietf.org/doc/html/rfc9512 specifies the official media-type to YAML as application/yaml. We had support for text/yaml (which is kept for backward compatibility), but this commit adds support for application/yaml as well.

KAG-5474

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

The https://datatracker.ietf.org/doc/html/rfc9512 specifies the official media-type
to YAML as `application/yaml`. We had support for `text/yaml` (which is kept for
backward compatibility), but this commit adds support for `application/yaml` as well.

Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
@github-actions github-actions bot added core/admin-api cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 26, 2024
@bungle bungle merged commit a6ccbb1 into master Sep 26, 2024
35 checks passed
@bungle bungle deleted the feat/admin-api-yaml-media-type branch September 26, 2024 16:29
@bungle bungle restored the feat/admin-api-yaml-media-type branch September 26, 2024 16:29
@bungle bungle deleted the feat/admin-api-yaml-media-type branch September 26, 2024 16:29
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

curiositycasualty pushed a commit that referenced this pull request Oct 15, 2024
…13713)

The https://datatracker.ietf.org/doc/html/rfc9512 specifies the official media-type
to YAML as `application/yaml`. We had support for `text/yaml` (which is kept for
backward compatibility), but this commit adds support for `application/yaml` as well.

Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
(cherry picked from commit a6ccbb1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/admin-api size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants