Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): use docker image to facilitate update-copyright step #13747

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

AndyZhang0707
Copy link
Collaborator

@AndyZhang0707 AndyZhang0707 commented Oct 12, 2024

Summary

It was not easy to install and figure out all the dependencies for the update-copyright script. This PR aims to install all the required dependencies into a docker image and use it to execute the update-copyright script.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-5297

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 12, 2024
DIR=$(dirname "$0")
PDIR=$(dirname "$DIR")

if ! (docker build -t kong/update-copyright ${DIR} && docker run -v ${PDIR}:/workspace --rm kong/update-copyright)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may consider publishing the docker image to reduce the build time in the future. But for now I've tried it several times docker always uses the local cached image thus it's not a big deal. @kikito any preferences?

@AndyZhang0707 AndyZhang0707 force-pushed the build/facilitate-update-copyright-script branch from 97e87c5 to 90a380e Compare October 14, 2024 02:09
@AndyZhang0707 AndyZhang0707 marked this pull request as ready for review October 14, 2024 02:31
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 14, 2024
@AndyZhang0707 AndyZhang0707 force-pushed the build/facilitate-update-copyright-script branch from 90a380e to 73a0a81 Compare October 14, 2024 07:03
@ADD-SP ADD-SP merged commit ef43c35 into master Oct 17, 2024
25 checks passed
@ADD-SP ADD-SP deleted the build/facilitate-update-copyright-script branch October 17, 2024 10:01
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@kikito
Copy link
Member

kikito commented Oct 17, 2024

We don't need cherrypicking this into kong-ee, there's a different process there for copyright handling

@team-gateway-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) backport release/3.8.x size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants