[backport -> release/3.8.x] fix(aws-lambda): add null handling for multiValueHeaders #13796
+47
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
team-gateway-bot
added
cherry-pick kong-ee
3 tasks
outsinre
reviewed
Oct 28, 2024
| @@ -89,6 +90,10 @@ local function validate_custom_response(response) | |||
| return nil, "body must be a string" | |||
| end | |||
|
|
|||
| if response.isBase64Encoded ~= nil and type(response.isBase64Encoded) ~= "boolean" then | |||
There was a problem hiding this comment.
Suggested change
| if response.isBase64Encoded ~= nil and type(response.isBase64Encoded) ~= "boolean" then | |
| if type(response.isBase64Encoded) ~= "boolean" then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release/3.8.x, triggered by a label in #13533.Original description
Summary
A small PR for adding a null handling code for the
multiValueHeadersfield. Also contains a small refactor to putisBase64Encodecheck into the validate function to keep consistency with other fieldsChecklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-6168