Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update warning msg [TDX-4640] #556

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

amerc15
Copy link
Contributor

@amerc15 amerc15 commented Sep 26, 2024

update warning msg when dev tries to create an application in a portal with no app reg enabled
remove link to create app when this warning appears

@amerc15 amerc15 requested a review from a team as a code owner September 26, 2024 18:24
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -127,7 +127,7 @@ describe('Application Registration', () => {
cy.visit('/my-apps')

cy.get('[data-testid="create-application-button"]').should('exist')
cy.get('[data-testid="create-application-link"]').should('exist')
cy.get('[data-testid="create-application-link"]').should('not.exist')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the contrapositive test for when it should be shown?

Copy link
Contributor

@andrewwylde andrewwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@amerc15 amerc15 merged commit e9e1a23 into main Sep 27, 2024
9 checks passed
@amerc15 amerc15 deleted the fix/update-warning-msg-with-no-app-reg-enabled branch September 27, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants