Update for GoPro HERO 2018 model

[amateusz]

GoPro HERO 2018 (entry-level model) has a firmware_version string H18.01.01.00.00. As it is a single H letter, we cannot use "Hxx" in response method anymore as it would be too inclusive. Therefore I've changed it to regexp and exact comparisons.

[KonradIT]

Code is not working as intented.

response = "HD5.03.02.51.00"

model = HD not HD5.

[amateusz]

Do you think then that model/identifier for HERO 2018 is simply a part preceding the dot i.e. H18…?
EDIT: LOL, so obvious 🤦 ; I'll just split it by the . delimeter.

[KonradIT]

Well, the problem is HD3 is also HERO3 which is not compatible, so the regex needs to include model == HD3.22

[amateusz]

Well, the problem is HD3 is also HERO3 which is not compatible, so the regex needs to include model == HD3.22

And exclude HD3 ? Do you allow for such a bodge ? To include HD3.22 but not HD3 ?
And include all other Hxx delimited by the . as well ?
I'm kind of leaning towards this comparisons as the way to go…

[KonradIT]

Yeah, HD3.22 are the HERO+ line that use udp.

[amateusz]

Do you have an example of HD3.22's firmware_version string ? (what I mean is.. is '22' a part of the model part or actual FW version)

[KonradIT]

Yup should be. Check goprowifihack for examples. Should be in the HERO folder.

[amateusz]

Just for the record it is HD3.22.01.50. I cannot make sense of those firmware strings to be spliced reliably. Could we transition to model numbers directly..? It seems to be omnipresent across all the models..

By the way is HERO+ LCD supported ? firmware_version = HD3.21… model 15

EDIT: I can actually make sense, but it starts to be bodgy. If there are 3 groups of numbers, then first group is important. If there are 4, then they are not important.. For now, for those HD3 / HD3.22, HDx.
Above there are three (HD3.22.01.50), so 22 is important… :puke: