Skip to content

Commit

Permalink
update crane comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sebkopf committed May 23, 2017
1 parent a0f8312 commit 84e6e86
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: lans2r
Title: Work with Look at NanoSIMS Data in R
Description: R interface for working with nanometer scale secondary ion mass
spectrometry (NanoSIMS) data exported from Look at NanoSIMS.
Version: 1.0.3
Version: 1.0.5
Authors@R: person("Sebastian", "Kopf", email = "sebastian.kopf@colorado.edu",
role = c("aut", "cre"))
URL: https://github.com/KopfLab/lans2r
Expand Down
31 changes: 26 additions & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,39 @@
This is a new package.
Resubmission of a new package after addressing issues raised in the first submission. Unfortunately a new warning appeared on win_builder that seems not related to this package (due to a mismatch between Rcpp and dplyr versions on win-builder) and hopefully will not be an issue for this submission (details below). Thank you for considering it for release.

## Test environments

* local OS X install, R 3.3.3
* local OS X install, R 3.4.0
* Ubuntu 12.04 (on travis-ci), R-oldrel, R-release, R-devel
* Windows Server 2012 R2 x64 on appveyor (oldrel, devel and release)
* win-builder (devel and release)

## R CMD check results

There were no NOTEs, ERRORs or WARNINGs.
#### on platforms other than win-builder

- This is a new release.
0 ERRORS | 0 WARNINGS | 0 NOTES

#### on win-builder

0 ERRORS | 1 WARNING | 1 NOTE

The warning (below) appears to be due to a mismatch between the Rcpp and dplyr versions installed on win-builder and has only appeared today. It is unrelated to the package and does not affect it passing all other tests without errors and warnings.

> * checking whether package 'lans2r' can be installed ... WARNING
Found the following significant warnings:
Warning: Installed Rcpp (0.12.11) different from Rcpp used to build dplyr (0.12.10).
Warning: Installed R (R Under development (unstable) (2017-05-20 r72713)) different from R used to build dplyr (R Under development (unstable) (2017-05-20 r72708)).

The note (below) is due to this being a new submission and because of spelling-related flagged words in DESCRIPTION. The words (nanometer, spectrometry) are spelled correctly according to Wikipedia (US spelling). The acronym (NanoSIMS) is the recognized way to refer to the type of mass-spectrometry data this package is concerned with and is an important keyword for any potential users to find this package.

> * checking CRAN incoming feasibility ... NOTE
Maintainer: 'Sebastian Kopf <sebastian.kopf@colorado.edu>'
New submission
Possibly mis-spelled words in DESCRIPTION:
NanoSIMS (2:26, 4:19, 4:56)
nanometer (3:43)
spectrometry (4:5)

## Reverse dependencies

This is a new release, there are currently no reverse dependencies for this package.
This is a new release, there are currently no reverse dependencies for this package.

0 comments on commit 84e6e86

Please sign in to comment.