Added type mappings tests and docs for ALL supported DBs - #2002
Open
AndreiKingsley wants to merge 17 commits into
Open
Added type mappings tests and docs for ALL supported DBs#2002AndreiKingsley wants to merge 17 commits into
AndreiKingsley wants to merge 17 commits into
Conversation
# Conflicts: # dataframe-jdbc/src/test/kotlin/org/jetbrains/kotlinx/dataframe/io/db/jdbcTypesTest.kt
Collaborator
|
Link it to the issue or create with the proper description |
AndreiKingsley
changed the title
…tails on `AdvancedDbType` and custom converters.
… MySQL. Standardize column type terminology and add unsupported types section.
…ndling, refine examples, and standardize terminology. Add support for `CLOB` type conversion.
…r `STRUCT` type details.
AndreiKingsley
marked this pull request as ready for review
August 19, 2026 14:11
Jolanrensen
reviewed
Aug 25, 2026
Jolanrensen
reviewed
Aug 25, 2026
Jolanrensen
reviewed
Aug 25, 2026
Jolanrensen
reviewed
Aug 25, 2026
Jolanrensen
reviewed
Aug 25, 2026
Jolanrensen
requested changes
Aug 25, 2026
Jolanrensen
left a comment
Jolanrensen
left a comment
Collaborator
There was a problem hiding this comment.
looks good overall :D
![jetbrains-air[bot]](https://avatars.githubusercontent.com/in/3314082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Really nice groundwork here — a couple of blocking spots to sort out first, then this is good to go.
Produced by AIR Automations. Name: Code Review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/61bd2991-de64-4a10-9895-fd00e7c1f42f?run=9f19003d-4019-41b7-bc81-8eadf4f49d13
…bc_types_tests_and_docs
…nying documentation updates
Jolanrensen
reviewed
Aug 29, 2026
| * | ||
| * val df = DataFrame.readSqlTable(connection, "events", dbType = sqliteCustom) | ||
| * ``` | ||
| * @sample [org.jetbrains.kotlinx.dataframe.samples.io.jdbc.SqliteSamples.complexSqlite] |
Collaborator
There was a problem hiding this comment.
Woop woop! KoDEx @sample from :samples in the wild :D I might need to check whether I can let it fail gracefully in the IntelliJ plugin... Now it's impossible to preview the rest of the doc unless you disable this sample.
Jolanrensen/KoDEx#112
Jolanrensen
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1736
For each
DBTypeimplementation, tests ALL possible sql types metadata -> expected ktype mappings and add info about it in docs.