PerfMeasurements: add ability to simulate measurements #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olichtne
force-pushed
the
simulate_perf_test
branch
3 times, most recently
from
2d73fd6
to
a9b14a9
Compare
|
Testing successful in beaker job: |
olichtne
force-pushed
the
simulate_perf_test
branch
from
a9b14a9
to
1367579
Compare
The "bottom" measurements - meaning the most core measurement in a list
of measurements that we may run can now be "simulated".
This means that instead of actually running the measurement
tools/commands we instead run the following command:
echo simulated start
And instead of returning real measurement results we return the same
structure of data with a single 0 value perf interval.
Combining this we can now run all of our ENRT recipes in a "simulation"
that preserves the number of commands per test recipe run and should
return results compatible with all of our tooling with just the basic 0
value.
The cpu measurement simulation does actually call the real measurement,
this is because this isn't a "bottom/core" measurement and is instead
designed to always wrap some other measurement.
Signed-off-by: Ondrej Lichtner <olichtne@redhat.com>
olichtne
force-pushed
the
simulate_perf_test
branch
from
1367579
to
a042e84
Compare
|
|
|
the tests still look ok so i'll merge this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "bottom" measurements - meaning the most core measurement in a list of measurements that we may run can now be "simulated".
This means that instead of actually running the measurement tools/commands we instead run the following command:
And instead of returning real measurement results we return the same structure of data with a single 0 value perf interval.
Combining this we can now run all of our ENRT recipes in a "simulation" that preserves the number of commands per test recipe run and should return results compatible with all of our tooling with just the basic 0 value.
The cpu measurement simulation does actually call the real measurement, this is because this isn't a "bottom/core" measurement and is instead designed to always wrap some other measurement.
Tests
I want to use this to generate baseline to threshold mapping for all of the tests and machines that we currently use so i'll link those jobs to here once i have confirmed everything works.
Reviews
(Please add a list of reviewers that should check the validity and sanity of
this merge request before it's accepted. Use the
@usernamesyntax. If youdon't know who to mention just link
@all.)Closes: #