LACP: rollback vlan setting, fix perf endpoints generation #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntent Raw response object is more useful for calling method as it provides wider range of functionality. The `response.content` are just bytes of response content.
Assigning port to a channel group has side effect of disconnecting it from all the VLANS. Those are not automatically restored after removing port from channel group. And therefore, we need to gather port's VLANs and restore connections during switch deconfiguration.
Endpoint rework changes from LNST-project#318 changed the way of generating IP enndpoints pairs from zipping 2 IP lists (dest IPs and source IPs) to generating them by taking a product of those 2 lists. Custom combination function allows developer to specify custom function for generating IP pairs, so e.g. instead of doing a product we can use zip or something more sophisticated.
…l IPs UDP over LACP requires lots of parallel perf processes. However, due to generating IP perf endpoints by doing a product on source and dest IPs recipe generated A WAY more processes (all IPs+ports to all IPS+ports) than expected. Using a zip instead of product generates exactly `perf_parellel_processes` processes: ```python >src_ips = [192.168.1.1, 192.168.1.2] >dst_ips = [10.0.0.1, 10.0.0.2] > >list(zip(src_ips, dst_ips)) [(192.168.1.1, 10.0.0.1), (192.168.1.2, 10.0.0.2)] ``` Hashing mode `layer2+3` identifies egress interface by dest IP+MAC. And therefore, source IP has no effect on that so we are good with just 1 source IP - 1 destination IP.
|
Approach discussed with dell support, there is no other way of assigning multiple ports to VLANs nor getting VLAN ports with just a single HTTP request. So this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR includes:
fix for rollbacking VLAN settings on Dell switches - Assigning port to a channel group has side effect of disconnecting
it from all the VLANS. Those are not automatically restored after
removing port from channel group.
perf endpoint generation fix - UDP over LACP requires lots of parallel perf processes. However, due to
generating IP perf endpoints by doing a product on source and dest IPs
recipe generated A WAY more processes (all IPs+ports to all IPS+ports)
than expected.
(see commit messages for further explanation)
Tests
Rollback tests:
J:8926338Endpoints generation fix:
J:8932918just a functional test of UDP test, without changes the recipe got aborted due to machine freezeReviews
@jtluka