Tests/Ping: log stdout #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Tluka <jtluka@redhat.com>
olichtne
requested changes
May 28, 2024
There was a problem hiding this comment.
you can also add the stdout to self._res_data['stdout'] so that this is accessible from the https://github.com/LNST-project/lnst/blob/master/lnst/Controller/Job.py#L88 job object and so that this is then also accessible in the lrc file.
Signed-off-by: Jan Tluka <jtluka@redhat.com>
olichtne
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes it's useful to have ping stdout available to analyze the connectivity issues.
Tests
Tested in RH Beaker lab J:9341216
Reviews
@olichtne