Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for "message of the day" #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add handling for "message of the day" #87

wants to merge 2 commits into from

Conversation

ewanas
Copy link
Collaborator

@ewanas ewanas commented Sep 22, 2022


Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@ewanas ewanas requested a review from meejah September 22, 2022 11:39
@donpui donpui mentioned this pull request Sep 22, 2022
6 tasks
@ewanas ewanas marked this pull request as ready for review September 22, 2022 12:28
Copy link
Collaborator

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this Go codebase in very much detail, so maybe not the best reviewer ... but there's not tests, does this repo not have unit tests, or ...?

@ewanas
Copy link
Collaborator Author

ewanas commented Sep 22, 2022

I haven't looked at this Go codebase in very much detail, so maybe not the best reviewer ... but there's not tests, does this repo not have unit tests, or ...?

C bindings don't have tests yet, but I will add tests for the Go changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants