Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 02-importing-data.md #208 and #289 #292

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Update 02-importing-data.md #208 and #289 #292

merged 5 commits into from
Jul 3, 2023

Conversation

jas58
Copy link
Contributor

@jas58 jas58 commented Jun 27, 2023

Added instructor note to "Create New" step 9
Added instructor note to "Going Further"

based on info in Issues #208 and #289

Added instructor note to "Create New" step 9
Added instructor note to "Going Further"
@jas58 jas58 requested a review from ostephens June 27, 2023 13:50
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-292

The following changes were observed in the rendered markdown documents:

 02-importing-data.md | 12 ++++++++++++
 md5sum.txt           |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-01 17:07:25 +0000

github-actions bot pushed a commit that referenced this pull request Jun 27, 2023
Copy link
Contributor

@ostephens ostephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be a blank line before the ::::: instructor markup otherwise it isn't correctly detected

I can't find any particular guidance on this but I'd suggest we keep the length of the various block markup consistent through the document

github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
removed ../ before internal link
github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
Copy link
Contributor Author

@jas58 jas58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ostephens I'm getting a bit turned around and will review tomorrow morning.

episodes/02-importing-data.md Outdated Show resolved Hide resolved
jas58 and others added 2 commits July 1, 2023 12:03
Copy link
Contributor Author

@jas58 jas58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Zhian's spaces (tab?) to maintain list structure
Unified length of fenced div colons for both instructor notes.
Added Zhian's revision for internal link

github-actions bot pushed a commit that referenced this pull request Jul 1, 2023
Copy link
Contributor Author

@jas58 jas58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is addressed in other commit thread?

@ostephens ostephens self-requested a review July 3, 2023 11:34
@ostephens ostephens merged commit aa14705 into main Jul 3, 2023
@ostephens ostephens deleted the jas58-patch-1 branch July 3, 2023 11:35
@ostephens
Copy link
Contributor

Thanks @jas58 - this all looks good to me!

github-actions bot pushed a commit that referenced this pull request Jul 3, 2023
Auto-generated via {sandpaper}
Source  : aa14705
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-07-03 11:35:31 +0000
Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1

Update 02-importing-data.md #208 and #289
github-actions bot pushed a commit that referenced this pull request Jul 3, 2023
Auto-generated via {sandpaper}
Source  : 535dbd1
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-03 11:36:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : aa14705
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-07-03 11:35:31 +0000
Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1

Update 02-importing-data.md #208 and #289
github-actions bot pushed a commit that referenced this pull request Jul 4, 2023
Auto-generated via {sandpaper}
Source  : 535dbd1
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-03 11:36:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : aa14705
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-07-03 11:35:31 +0000
Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1

Update 02-importing-data.md #208 and #289
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
Auto-generated via {sandpaper}
Source  : 535dbd1
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-03 11:36:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : aa14705
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-07-03 11:35:31 +0000
Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1

Update 02-importing-data.md #208 and #289
github-actions bot pushed a commit that referenced this pull request Jul 18, 2023
Auto-generated via {sandpaper}
Source  : 535dbd1
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-03 11:36:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : aa14705
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-07-03 11:35:31 +0000
Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1

Update 02-importing-data.md #208 and #289
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
Auto-generated via {sandpaper}
Source  : 535dbd1
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-03 11:36:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : aa14705
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-07-03 11:35:31 +0000
Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1

Update 02-importing-data.md #208 and #289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants