Revise docs on Library Concept #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrgn
approved these changes
Jan 10, 2024
|
Thanks! 🙂
Doesn't matter too much for this repository - if the diff is not too large it's fine to edit multiple pages in one PR, but for very large diffs it's usually helpful to split them into separate PRs since this makes review easier and faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was reading through the LibrePCB docs and found that this page's writing was a little unclear. This PR revises it and fixes some grammatical issues. Thanks for this amazing project!
P.S. If I find any more pages like this, would you rather have changes for multiple pages be all in one PR or separated out?