feat(ui): shared clickable-affordance accent for task-card rows - #3
Closed
Limdongcheng wants to merge 1 commit into
Closed
feat(ui): shared clickable-affordance accent for task-card rows#3Limdongcheng wants to merge 1 commit into
Limdongcheng wants to merge 1 commit into
Conversation
Task-card rows that expand or reveal content on click (processing step rows, CRAFT signal groups, region rows) rendered as plain text until hovered, so users never discovered they were clickable. The Ribbon already has a clickable visual language — enabled button glyphs carry `Visuals::hyperlink_color` — so a new `ui::affordance` module exposes that colour (`clickable_tint`) plus a `selectable_row` helper that tints a row's leading glyph with it while the label keeps the theme text colour. The three click-to-enter rows now render through the helper; Statistics and Curve Fit cards expose their actions through framed buttons and combo boxes already, so they need no change.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Task-card rows that expand or reveal content on click (processing step rows, CRAFT signal groups, region rows) rendered as plain text until hovered, so users never discovered they were clickable.
Fix
The Ribbon already has a clickable visual language — enabled button glyphs carry
Visuals::hyperlink_color. A newui::affordancemodule exposes that colour (clickable_tint) plus aselectable_rowhelper that tints a row's leading glyph with it while the label keeps the theme text colour, so "this text is clickable" reads identically on every surface instead of each card inventing its own.The three click-to-enter rows now render through the helper. Statistics and Curve Fit cards already expose their actions through framed buttons and combo boxes, so they need no change. Scope is deliberately limited to the clickable-affordance semantic — no app-wide recolouring.
Tests
A unit test pins
clickable_tintto the Ribbon glyph colour in both themes so the visual language cannot silently fork.cargo pr-checkpasses.Part 2 of the stack, based on
fix/task-card-geometry(#2).