Add managed string and array reads - #147
Open
ero-qt wants to merge 21 commits into
Open
Conversation
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #146.
Part of #149.
Adds
read_stringandread_arrayto both backends'Module. The crate had no way to read aSystem.Stringor a managed array; the raw route is a fixed-size read at a memorized header offset, unchecked against the count and wrong at the other width.read_stringreads the character count, then exactly that many UTF-16 characters. Counts past the buffer, negative counts, and null references fail rather than truncate.read_arraydoes the same with the length, judged at pointer width before narrowing so a huge value can't slip through as its low half. Element type is the caller's claim, likeProcess::read; the docs list the mappings (managedcharisu16, Rustcharnever matches).ArrayVecshows up in a public signature for the first time; the crate already re-exports arrayvec.