Add reference element reads - #153
Open
ero-qt wants to merge 27 commits into
Open
Conversation
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #152.
Part of #149.
Adds
read_reference_arrayandread_reference_list, which hand back the elements' object addresses, plusread_string_objectto read a string at one of those addresses (read_stringis now just a dereference plus that). That makesstring[]andList<string>readable, which the readers couldn't do until now.Reference elements are pointers at the target's width, so a width claim through
read_arraycompiles on either width and silently answers garbage addresses on the wrong one. These own the width instead. Null elements come back as null addresses at their positions; only a null collection reference refuses. Filtering nulls is the caller's one-liner, and positions matter if you're lining indices up against another array.Custom-class elements work the same way: object address plus
get_field_offsetreads fields directly.