-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Continuous Integration script to reproduce error assert q.is_cuda and k.is_cuda and v.is_cuda
#113
Open
richelbilderbeek
wants to merge
1
commit into
MAGICS-LAB:main
Choose a base branch
from
UPPMAX:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richelbilderbeek
changed the title
Add Continuous Integration script
Add Continuous Integration script to reproduce error Sep 9, 2024
assert q.is_cuda and k.is_cuda and v.is_cuda
Ah, you cannot see the errors. They are here (you need to have been logged in to GitHub) and pasted below for convenience:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear DNABERT 2 maintainer,
With this Pull Request I'd like to prove that the documentation is incomplete, by reproducing the error
This error is reported too in #11, #20, #34, #96 and #112.
I made the error reproducible with the script in
.github/workflow/check_build.yaml
, where I copy-paste the install process only. I simply followed the install procedure in the README, using the recommended Python 3.8, yet without the conda setup:The script it runs is copied from the README too:
The error log is shown in the next message below.
I think that a user should be able to install a Python module and run example code with success by reading the documentation, hence I think the documentation is incomplete or the error message given is not helpful enough (#112).
I hope you appreciate the effort I put in to make DNABERT 2 even better for everyone. Maybe using CI scripts is new to you, I'd be happy to discuss their pros and cons and I'd be happy to maintain such scripts for my users :-)
Cheers, Richel Bilderbeek