test: smoke-test the LOC bot from a fork (do not merge) - #1755
Closed
sbryngelson wants to merge 1 commit into
Closed
test: smoke-test the LOC bot from a fork (do not merge)#1755sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
Lines of Code
|
Member
Author
|
Verified: fork PRs get commented (pull_request_target working as intended), and the merge-base counting reported +1 rather than the ~-1403 that comparing against master's tip would have produced on this 32-commit-stale fork. Closing — not for merge. |
Contributor
There was a problem hiding this comment.
Pull request overview
Smoke-tests fork PR handling and merge-base LOC counting. The intentional declaration split adds one line without changing behavior.
Changes:
- Splits one integer declaration into two lines.
- Produces the expected
+1LOC delta.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second smoke test for the bot from #1753, this time from a fork — the case #1754 could not cover. Do not merge — will be closed.
Two things under test:
Fork PRs get commented at all. This is the entire reason the workflow uses
pull_request_target; underpull_requesta fork'sGITHUB_TOKENis read-only and the comment would fail. It also exercises fetchingrefs/pull/N/headfor a fork head.Merge-base counting. This fork's master is 32 commits stale, and its
src/tree differs from upstream master by -1403 lines. Counting against master's tip would blame this PR for roughly -1403 lines of other people's deletions. Counting against the merge base should report +1 — the one declaration line this PR actually splits.Expected comment:
m_global_parameters.fpp +1,**total** +1. Anything near -1403 means the merge-base logic is broken.