Skip to content

test: smoke-test the LOC bot from a fork (do not merge) - #1755

Closed
sbryngelson wants to merge 1 commit into
MFlowCode:masterfrom
sbryngelson:test/loc-bot-fork
Closed

test: smoke-test the LOC bot from a fork (do not merge)#1755
sbryngelson wants to merge 1 commit into
MFlowCode:masterfrom
sbryngelson:test/loc-bot-fork

Conversation

@sbryngelson

Copy link
Copy Markdown
Member

Second smoke test for the bot from #1753, this time from a fork — the case #1754 could not cover. Do not merge — will be closed.

Two things under test:

  1. Fork PRs get commented at all. This is the entire reason the workflow uses pull_request_target; under pull_request a fork's GITHUB_TOKEN is read-only and the comment would fail. It also exercises fetching refs/pull/N/head for a fork head.

  2. Merge-base counting. This fork's master is 32 commits stale, and its src/ tree differs from upstream master by -1403 lines. Counting against master's tip would blame this PR for roughly -1403 lines of other people's deletions. Counting against the merge base should report +1 — the one declaration line this PR actually splits.

Expected comment: m_global_parameters.fpp +1, **total** +1. Anything near -1403 means the merge-base logic is broken.

@sbryngelson
sbryngelson requested a balanced review from Copilot August 23, 2026 22:58
@github-actions

Copy link
Copy Markdown

Lines of Code

File Lines Diff
src/simulation/m_global_parameters.fpp 726 +1
Directory Lines Diff
simulation 26387 +1
total 44075 +1

@sbryngelson

Copy link
Copy Markdown
Member Author

Verified: fork PRs get commented (pull_request_target working as intended), and the merge-base counting reported +1 rather than the ~-1403 that comparing against master's tip would have produced on this 32-commit-stale fork. Closing — not for merge.

@sbryngelson
sbryngelson deleted the test/loc-bot-fork branch August 23, 2026 23:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Smoke-tests fork PR handling and merge-base LOC counting. The intentional declaration split adds one line without changing behavior.

Changes:

  • Splits one integer declaration into two lines.
  • Produces the expected +1 LOC delta.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants