FarGroupgh-782: Stack corruption in Process list plugin

MKadaner · Jan 27, 2024 · fba6686 · fba6686
1 parent 8484c30
commit fba6686
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/plugins/proclist/changelog b/plugins/proclist/changelog
@@ -1,3 +1,7 @@
+drkns 2024-01-27 16:45:12+00:00 - build 210
+
+1. gh-782: Stack corruption in Process list plugin.
+
 drkns 2023-05-08 19:32:14+01:00 - build 209
 
 1. Enable consteval in fmt.

diff --git a/plugins/proclist/handles.cpp b/plugins/proclist/handles.cpp
@@ -101,10 +101,10 @@ static std::wstring GetFileName(HANDLE Handle)
 		{
 			static DWORD WINAPI GetFileNameThread(PVOID Param)
 			{
-				DWORD iob[2];
-				BYTE info[256];
+				IO_STATUS_BLOCK iob;
+				FILE_BASIC_INFO info;
 				const auto FileBasicInformation = 4;
-				pNtQueryInformationFile(Param, iob, info, sizeof(info), FileBasicInformation);
+				pNtQueryInformationFile(Param, &iob, &info, sizeof(info), FileBasicInformation);
 				return 0;
 			}
 		};

diff --git a/plugins/proclist/version.hpp b/plugins/proclist/version.hpp
@@ -5,7 +5,7 @@
 
 #include <farversion.hpp>
 
-#define PLUGIN_BUILD 209
+#define PLUGIN_BUILD 210
 #define PLUGIN_DESC L"Process List for FAR Manager"
 #define PLUGIN_NAME L"ProcList"
 #define PLUGIN_FILENAME L"ProcList.dll"