-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inactive top cell global ocean test case #164
Draft
cbegeman
wants to merge
16
commits into
MPAS-Dev:main
Choose a base branch
from
cbegeman:add_inactive_top_cell
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Aug 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dadeb44 - Browse repository at this point
Copy the full SHA dadeb44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1da84c9 - Browse repository at this point
Copy the full SHA 1da84c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83233de - Browse repository at this point
Copy the full SHA 83233deView commit details -
Configuration menu - View commit details
-
Copy full SHA for c059ee5 - Browse repository at this point
Copy the full SHA c059ee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d7e757 - Browse repository at this point
Copy the full SHA 5d7e757View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7a8094 - Browse repository at this point
Copy the full SHA c7a8094View commit details
Commits on Aug 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 95e0ca2 - Browse repository at this point
Copy the full SHA 95e0ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c75a01b - Browse repository at this point
Copy the full SHA c75a01bView commit details -
Add mesh and out filename when cropping inactive top
Use `minLevelCell` instead of an argument to determine the number of inactive top levels.
Configuration menu - View commit details
-
Copy full SHA for 98061df - Browse repository at this point
Copy the full SHA 98061dfView commit details -
Store the `inactive_top_comp_subdir` so we know what files to compare with during validation. Use `ds.load()` when modifying `minLevelCell` in the initial state to prevent issues with reading from and writing to the same file. Crop inactive top cells after writing out the modified initial state (because we now use the modified `minLevelCell`). Set the default to `inactive_top_cells = 0` in a new `init.cfg` instead of the config file for the QU240 mesh.
Configuration menu - View commit details
-
Copy full SHA for ba3b04a - Browse repository at this point
Copy the full SHA ba3b04aView commit details -
Move cropping of inactive top cells to ForwardStep so it is explicitly included as an output of that step. Give `init.nc` as the mesh file for cropping. For validation, point to the output file from the version of the performance test without inactive top cells for `filename2`.
Configuration menu - View commit details
-
Copy full SHA for 0bcab9a - Browse repository at this point
Copy the full SHA 0bcab9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a15e8f - Browse repository at this point
Copy the full SHA 2a15e8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a41fe5 - Browse repository at this point
Copy the full SHA 2a41fe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84aef87 - Browse repository at this point
Copy the full SHA 84aef87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8308c57 - Browse repository at this point
Copy the full SHA 8308c57View commit details -
Configuration menu - View commit details
-
Copy full SHA for c123941 - Browse repository at this point
Copy the full SHA c123941View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.