Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inactive top cell global ocean test case #164

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    dadeb44 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1da84c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83233de View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c059ee5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5d7e757 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c7a8094 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Configuration menu
    Copy the full SHA
    95e0ca2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c75a01b View commit details
    Browse the repository at this point in the history
  3. Add mesh and out filename when cropping inactive top

    Use `minLevelCell` instead of an argument to determine the number
    of inactive top levels.
    xylar authored and cbegeman committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    98061df View commit details
    Browse the repository at this point in the history
  4. Update the init test case

    Store the `inactive_top_comp_subdir` so we know what files to
    compare with during validation.
    
    Use `ds.load()` when modifying `minLevelCell` in the initial state
    to prevent issues with reading from and writing to the same file.
    
    Crop inactive top cells after writing out the modified initial
    state (because we now use the modified `minLevelCell`).
    
    Set the default to `inactive_top_cells = 0` in a new `init.cfg`
    instead of the config file for the QU240 mesh.
    xylar authored and cbegeman committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ba3b04a View commit details
    Browse the repository at this point in the history
  5. Update performance test

    Move cropping of inactive top cells to ForwardStep so it is
    explicitly included as an output of that step.
    
    Give `init.nc` as the mesh file for cropping.
    
    For validation, point to the output file from the version of the
    performance test without inactive top cells for `filename2`.
    xylar authored and cbegeman committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    0bcab9a View commit details
    Browse the repository at this point in the history
  6. Add a test suite for inactive top cells

    xylar authored and cbegeman committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    2a15e8f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2a41fe5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    84aef87 View commit details
    Browse the repository at this point in the history
  9. Fixup vertical grid offset

    cbegeman committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8308c57 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c123941 View commit details
    Browse the repository at this point in the history