Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to the RRM tutorial #671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Aug 16, 2023

Checklist

  • Documentation has been built locally and changes look as expected

@xylar xylar added documentation Improvements or additions to documentation ocean labels Aug 16, 2023
@xylar xylar self-assigned this Aug 16, 2023
@xylar
Copy link
Collaborator Author

xylar commented Aug 16, 2023

@irenavankova, can you take a look at this and recommend any further fixes? We could also add a broader introduction to the structure of the global ocean test cases if you like, or you could make your own PR for that.

@xylar
Copy link
Collaborator Author

xylar commented Aug 16, 2023

To fix

We need to switch to:

        self._add_tests(mesh_names=['YAM', 'YAMwISC'],
                        DynamicAdjustment=WC14DynamicAdjustment)

This means the step-by-step instructions somehow need to work in combination with _add_tests().

It might be worth mentioning that you can do only the mesh with or without ice-shelf cavities if that makes more sense for your mesh.

It would be worth pointing to the Kuroshio meshes as an example of mostly sharing the same configuration and only having a few config options, etc. that are explicitly defined for each mesh.

Many updates needed to describe new dynamic adjustment test case.

@xylar xylar added the in progress This PR is not ready for review or merging label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation in progress This PR is not ready for review or merging ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant