Skip to content

Commit

Permalink
Merge pull request #50 from MPEGGroup/cleanups
Browse files Browse the repository at this point in the history
Cleanups

There are a lot of updates and we don't expect anyone to actually review all of this. This was done using the scripts to parse the specifications (mostly). User defined features are cleaned up manually.
  • Loading branch information
podborski authored Sep 6, 2023
2 parents 6f80fff + bfd1686 commit 53f1e3d
Show file tree
Hide file tree
Showing 88 changed files with 1,484 additions and 1,288 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -360,4 +360,7 @@ pyrightconfig.json
.history
.ionide

# End of https://www.toptal.com/developers/gitignore/api/visualstudiocode,python,node,macos
# End of https://www.toptal.com/developers/gitignore/api/visualstudiocode,python,node,macos


src/mp4ra
2 changes: 1 addition & 1 deletion conformance-search/src/components/FeatureComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function FeatureComponent({ feature }: { feature: SearchResultRef
>
<div className="flex flex-row items-start p-3 !pb-0">
<div className="grow">
<h3 className="-mb-1 text-xs font-bold">Feature</h3>
<h3 className="-mb-1 text-xs font-bold">Feature &bull; {feature.item.spec}</h3>
<h2 className="text-3xl font-extralight tracking-tight">{feature.item.name}</h2>
</div>
<button
Expand Down
35 changes: 20 additions & 15 deletions conformance-search/src/types/json.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
export type Coverage = {
not_found: {
count: number;
percentage: number;
boxes: string[];
missing_extensions: string[];
paths: string[];
};
lists: {
boxes: {
covered: Array<string>;
not_covered: Array<string>;
under_consideration: Array<string>;
covered: string[];
not_covered: string[];
under_consideration: string[];
};
features: {
covered: Array<string>;
not_covered: Array<string>;
under_consideration: Array<string>;
covered: string[];
not_covered: string[];
under_consideration: string[];
};
};
path_file_map: {
Expand All @@ -28,8 +35,6 @@ export type Coverage = {
count: number;
published_features: number;
under_consideration_features: number;
features_from_spec: number;
features_from_file: number;
};
files: {
count: number;
Expand All @@ -39,15 +44,16 @@ export type Coverage = {
boxes: {
count: number;
};
spec_info: Array<{
spec_info: {
ISO: string;
name: string;
version: number;
date: number;
mp4ra_reference: string[];
link: string;
amendmends?: Array<string>;
corrigenda?: Array<string>;
}>;
amendmends?: string[];
corrigenda?: string[];
}[];
};

export type FileMetadata = {
Expand All @@ -65,8 +71,8 @@ export type FileMetadata = {
conforms_to: {
ISO: string;
version: number;
amendmends?: Array<string>;
corrigenda?: Array<string>;
amendmends?: string[];
corrigenda?: string[];
}[];
notes:
| string
Expand All @@ -79,7 +85,6 @@ export type FeatureFileMap = {
key: string;
description: string;
spec: string;
added_from_file: "spec" | "file";
files: string[];
};

Expand Down
11 changes: 1 addition & 10 deletions data/file_features/published/3gp/female_amr67DTX_hinted.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,7 @@
"version": 1,
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Movie box",
"track reference",
"video track",
"audio track",
"sync table",
"RTP hint tracks"
],
"features": ["video track", "audio track", "RTP hint tracks"],
"notes": "",
"license": "",
"rel_filepath": "./female_amr67DTX_hinted.3gp",
Expand Down
11 changes: 1 addition & 10 deletions data/file_features/published/3gp/female_amr67_hinted.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,7 @@
"version": 1,
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Movie box",
"track reference",
"video track",
"audio track",
"sync table",
"RTP hint tracks"
],
"features": ["video track", "audio track", "RTP hint tracks"],
"notes": "",
"license": "",
"rel_filepath": "./female_amr67_hinted.3gp",
Expand Down
10 changes: 1 addition & 9 deletions data/file_features/published/3gp/male_amr122.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,7 @@
"version": 1,
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Movie box",
"track reference",
"video track",
"audio track",
"sync table"
],
"features": ["video track", "audio track"],
"notes": "",
"license": "",
"rel_filepath": "./male_amr122.3gp",
Expand Down
10 changes: 1 addition & 9 deletions data/file_features/published/3gp/male_amr122DTX.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,7 @@
"version": 1,
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Movie box",
"track reference",
"video track",
"audio track",
"sync table"
],
"features": ["video track", "audio track"],
"notes": "",
"license": "",
"rel_filepath": "./male_amr122DTX.3gp",
Expand Down
12 changes: 1 addition & 11 deletions data/file_features/published/3gp/pdin_example.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,7 @@
"version": 1,
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"video track",
"sync table",
"progressive dnload box",
"avc1 sample entry"
],
"features": ["video track"],
"notes": "",
"license": "",
"rel_filepath": "./pdin_example.3gp",
Expand Down
12 changes: 1 addition & 11 deletions data/file_features/published/3gp/rs_example_r1.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,10 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"video track",
"audio track",
"track selection box",
"sync table",
"sample groups",
"rate share group",
"Interleaved data",
"mp4a sample entry",
"avc1 sample entry"
"mp4a sample entry"
],
"notes": "",
"license": "",
Expand Down
10 changes: 0 additions & 10 deletions data/file_features/published/isobmff/01_simple.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,8 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"track reference",
"video track",
"audio track",
"ctts offsets",
"sync table",
"Copyright box",
"Interleaved data",
"Systems tracks etc.",
"IOD box",
Expand Down
14 changes: 2 additions & 12 deletions data/file_features/published/isobmff/02_dref_edts_img.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,9 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"track reference",
"edit list",
"audio track",
"image track (no sync table)",
"data ref to other file",
"compact stz2",
"Copyright box",
"image track",
"data reference to other file",
"Interleaved data",
"Systems tracks etc.",
"IOD box",
Expand Down
12 changes: 1 addition & 11 deletions data/file_features/published/isobmff/03_hinted.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,11 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"track reference",
"video track",
"ctts offsets",
"sync table",
"Copyright box",
"Interleaved data",
"RTP hint tracks",
"hint track setup",
"sdp boxes (moov and track)",
"sdp boxes",
"hint stats boxes",
"RTP immediate constructor",
"RTP sample contructor with track reference",
Expand Down
13 changes: 1 addition & 12 deletions data/file_features/published/isobmff/04_bifs_video.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,8 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"track reference",
"video track",
"data ref to other file",
"compact stz2",
"ctts offsets",
"sync table",
"Copyright box",
"data reference to other file",
"Systems tracks etc.",
"IOD box",
"mp4v sample entry",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,9 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"track reference",
"video track",
"ctts offsets",
"sync table",
"Protected streams (basic)",
"Copyright box",
"file-level",
"item naming etc.",
"Protected basic",
"item naming",
"Systems tracks etc.",
"IOD box",
"mp4v sample entry",
Expand Down
9 changes: 1 addition & 8 deletions data/file_features/published/isobmff/06_bifs.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,7 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"late' order (mdat first)",
"track enabled bit",
"sync table",
"Copyright box",
"late order",
"Systems tracks etc.",
"IOD box",
"mp4s sample entry",
Expand Down
11 changes: 1 addition & 10 deletions data/file_features/published/isobmff/07_bifs_sprite.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,7 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"late' order (mdat first)",
"track enabled bit",
"track reference",
"sync table",
"shadow sync",
"Copyright box",
"late order",
"Systems tracks etc.",
"IOD box",
"mp4s sample entry",
Expand Down
8 changes: 0 additions & 8 deletions data/file_features/published/isobmff/08_bifs_carousel_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"sync table",
"Copyright box",
"sample dependency",
"Systems tracks etc.",
"IOD box",
Expand Down
9 changes: 1 addition & 8 deletions data/file_features/published/isobmff/09_text.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,9 @@
"published": true,
"associated_files": [],
"features": [
"Ordinary box",
"FTYP box",
"Free/skip",
"Movie box",
"normal' order (moov-mdat)",
"track enabled bit",
"unknown track type",
"unknown codec type",
"Copyright box",
"several sample description"
"multiple sample descriptions"
],
"notes": "",
"license": "",
Expand Down
Loading

0 comments on commit 53f1e3d

Please sign in to comment.