Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated boxes support #106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Deprecated boxes support #106

wants to merge 5 commits into from

Conversation

DenizUgur
Copy link
Collaborator

fixes #72

The support for deprecated boxes has been added. When all deprecated boxes are added to this PR we can merge it.

@podborski podborski marked this pull request as ready for review October 18, 2023 23:37
Copy link
Member

@podborski podborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@podborski
Copy link
Member

podborski commented Oct 18, 2023

@cconcolato do you see any deprecated boxes in this list? (note that a lot of those below are brands / handlers and they are already handled in #101 and #102, but if you see any deprecated ones we should try to add them in this PR if possible.

2023-10-18 16:35:15.204 | WARNING | construct.boxes:main:365 - Missing boxes in standard features (122): ['1pic', 'Exif', 'aSEI', 'auvd', 'auxv', 'avci', 'avcs', 'bitr', 'cdec', 'cgsc', 'clip', 'comp', 'crgn', 'crhd', 'ctab', 'ecam', 'elvi', 'eroi', 'esds', 'evbi', 'evbs', 'evir', 'evm1', 'evmi', 'evms', 'feci', 'fgsc', 'frar', 'geom', 'hapt', 'heic', 'heim', 'heis', 'heix', 'hevc', 'hevm', 'hevs', 'hevx', 'hvce', 'hvci', 'hvcx', 'hvti', 'icam', 'iden', 'ilvi', 'imap', 'iods', 'iovl', 'iphd', 'iso2', 'iso3', 'iso4', 'iso5', 'iso6', 'iso7', 'iso8', 'iso9', 'isoa', 'isob', 'isoc', 'isom', 'jpeg', 'jpgs', 'kmat', 'levl', 'lhte', 'lhti', 'load', 'm4ae', 'm7hd', 'mask', 'matt', 'mela', 'mif1', 'mif2', 'mime', 'mint', 'mjhd', 'mjpg', 'mp41', 'mp42', 'mp4a', 'mp4s', 'mp4v', 'mp71', 'mp7b', 'mp7t', 'mpsz', 'msf1', 'mski', 'mtyp', 'nclx', 'nras', 'null', 'nvws', 'ochd', 'odhd', 'pict', 'plvi', 'pnot', 'prfl', 'prof', 'rICC', 'relo', 'resc', 'rgan', 'rtvi', 'scsz', 'sdhd', 'slid', 'soun', 'spsc', 'spvi', 'tesc', 'tile', 'unif', 'vide', 'volv', 'vvhd', 'vvic', 'vvis', 'vwsc']

I added the deprecated from ISOBMFF in c955f41 but didn't check others.

Related: MPEGGroup/FileFormat#79


Update

WARNING : Missing boxes in standard features (66): ['Exif', 'aSEI', 'auvd', 'bitr', 'cdec', 'cgsc', 'clip', 'crgn', 'crhd', 'ctab', 'ecam', 'elvi', 'eroi', 'esds', 'evir', 'evm1', 'feci', 'fgsc', 'frar', 'geom', 'icam', 'iden', 'ilvi', 'imap', 'iods', 'iovl', 'iphd', 'kmat', 'levl', 'load', 'm4ae', 'm7hd', 'mask', 'matt', 'mela', 'mime', 'mint', 'mjhd', 'mjpg', 'mp4a', 'mp4s', 'mp4v', 'mpsz', 'mski', 'mtyp', 'nclx', 'nvws', 'ochd', 'odhd', 'plvi', 'pnot', 'prfl', 'prof', 'rICC', 'resc', 'rgan', 'rtvi', 'scsz', 'sdhd', 'slid', 'spsc', 'spvi', 'tesc', 'tile', 'vvhd', 'vwsc']

@podborski
Copy link
Member

we should also incorporate the outcome of MPEGGroup/FileFormat#47 I believe we can remove:

{
      "fourcc": "svop",
      "description": "SVC dependency range",
      "containers": ["sgpd"],
      "type": "Box",
      "syntax": "class SVCDependencyRangeBox extends Box('svop') {\n\tunsigned int(3) min_dependency_id;\n\tunsigned int(3) min_temporal_id;\n\tbit(6) reserved = 0;\n\tunsigned int(4) min_quality_id;\n\tunsigned int(3) max_dependency_id;\n\tunsigned int(3) max_temporal_id;\n\tbit(6) reserved = 0;\n\tunsigned int(4) max_quality_id;\n}"
    },

as we already have:

{
      "fourcc": "svdr",
      "description": "SVC dependency range",
      "containers": ["scif"],
      "type": "Box",
      "syntax": "class SVCDependencyRangeBox extends Box('svdr') {\n\tunsigned int(3) min_dependency_id;\n\tunsigned int(3) min_temporal_id;\n\tbit(6) reserved = 0;\n\tunsigned int(4) min_quality_id;\n\tunsigned int(3) max_dependency_id;\n\tunsigned int(3) max_temporal_id;\n\tbit(6) reserved = 0;\n\tunsigned int(4) max_quality_id;\n}"
    },

@DenizUgur
Copy link
Collaborator Author

Should we deprecate it instead of removing?

@podborski podborski added the enhancement New feature or request label Oct 19, 2023
@podborski
Copy link
Member

Should we deprecate it instead of removing?

no, this was added by mistake. I believe it was a typo in the spec

@DenizUgur
Copy link
Collaborator Author

we should also incorporate the outcome of MPEGGroup/FileFormat#47 I believe we can remove:

  "fourcc": "svop",

Is this related to #67?

@DenizUgur
Copy link
Collaborator Author

@podborski Should we merge this or would you like to keep it open to add all the deprecated boxes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling deprecated 4CCs
2 participants