-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring, Bug fixes and a couple new features. #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
though command abilities are kinda both commands and abilities
trying to fix the broken strings.
I'm trying to figure out a plan for dealing with string id's not matching in different languages.
Some values are now read only and no longer static. So if we wanted to reload the list of files we could just update the files value in player class. Changes names to camalcase
removed a couple of structs we aren't using. as we just need the 50 bytes header and not really needed to know what the data is to use it with ffmpeg.
…o persist for each frame.
camera's is now using ireadonlylist instead of Ilist changed XYZ from array to a value tuple of 3 Vector3's with varible names added pan per maki.
…ome so it is scaled 1.1f in the X and Z direction so it won't interecept the mountains now.
… the lunarcry textures for battle. had to use classic dims for uvs
…to == so the default was 0 and not 1.
stupid hacks to fix Rinoa and Ward in remaster. might break when going above 3X upscale if you choose to upscale more crop off dead bottom 128 pixels from SE's render. also hack adjusts aspect ratio to handle the eye closing animation frames. in remaster you just need to shift all the uv's to the right when eyes close.
…a new struct for 16 bit color maybe better than method?
…ome more cs files.
also fixed unit test so it ran.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Month of changes.
Bug fixes
New features
- One issue noise in alpha channel from PNGs will be rendered by OpenVIII. I created a tool to filter out the noise.
Refactoring
Related issues
#165 #164 #158 #157
#160