Remove dependency of proj_matrix during scoring #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finalize feature deletes the proj_matrix, but basic projector assumes it exists. remove dependency.
kristian-georgiev
approved these changes
Jan 5, 2024
kristian-georgiev
added a commit
that referenced
this pull request
Jan 17, 2024
* fix finalize features floods CPU memory: remove log and load mapped gradients to device (#59) * torch load gradients to device instead of CPU during finalize loading data directly on device instead of moving from CPU to GPU in score computation steps * Remove logging of raw tensors * Remove dependency of proj_matrix during scoring (#61) finalize feature deletes the proj_matrix, but basic projector assumes it exists. remove dependency. * fix grads type check in iterative gradient computers Co-authored-by: TheaperDeng <junweid2.illinois.edu> * [added feature] regularization term for inv(xtx) calculation (#63) * Updated score_computers.py for lambda_reg * Updated traker.py to include a lambda_reg term in arguments * minor fixes --------- Co-authored-by: Junwei Deng < junweid2@illinois.edu> Co-authored-by: Jiadong Guo <jaedon.guo@gmail.com> Co-authored-by: heale04 <136350745+heale04@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalize feature deletes the proj_matrix, but basic projector assumes it exists. remove dependency.