Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rails 7 gems in gemspec #119

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Jan 12, 2024

Allow rails 7 gems in gemspec

Note, I dropped ruby 2.5/rails 5.2 from the matrix since they are far EOL.

@agrare
Copy link
Member

agrare commented Jan 12, 2024

@jrafanie can you add rails 7.0 to the test matrix?

@jrafanie
Copy link
Member Author

Sure, I'll manually push to this one. There's a handful of lib gems like this.

@jrafanie jrafanie force-pushed the allow_rails_7 branch 5 times, most recently from d95f1b5 to ef84c78 Compare January 12, 2024 22:28
@miq-bot
Copy link
Member

miq-bot commented Jan 12, 2024

Checked commits jrafanie/inventory_refresh@adef7e8~...be68fe7 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@jrafanie
Copy link
Member Author

@jrafanie can you add rails 7.0 to the test matrix?

hey, that was easy... I had to drop 2.5/5.2 and add ruby 3.1 which required me to safe_load aliases: true in two places. Since we're supporting old rubies here, I kept it with safe_load since safe_load_file was only added fairly recently and I don't know if it always supported passing aliases: true. I went with the ugly but more portable method.

@agrare agrare merged commit b7ce09a into ManageIQ:master Jan 16, 2024
9 checks passed
@jrafanie jrafanie deleted the allow_rails_7 branch January 16, 2024 20:38
agrare added a commit that referenced this pull request Feb 8, 2024
Changed
- Update GitHub Actions versions (#117)
- Update actions/checkout version to v4 (#118)
- Allow rails 7 gems in gemspec (#119)
@agrare
Copy link
Member

agrare commented Feb 8, 2024

Released v2.1.0 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants