Fix rails 7 deprecation on ActiveRecord::Base.default_timezone #124
Conversation
| if default_timezone_utc? | ||
| Time.now.utc | ||
| else | ||
| Time.zone.now | ||
| end |
There was a problem hiding this comment.
Hm if the default_timezone is UTC then aren't Time.now.utc and Time.zone.now the same thing? Could we simplify this to just Time.zone.now
There was a problem hiding this comment.
Oooh, I hear you saying, can we delete this?
irb(main):009:0> Time.zone.now.class
=> ActiveSupport::TimeWithZone
irb(main):010:0> Time.now.utc.class
=> TimeLet me see if there is a reason it was written like this.
There was a problem hiding this comment.
Yeah if we're concerned about Time vs ActiveSupport::TimeWithZone we could always Time.zone.now.to_time
There was a problem hiding this comment.
It was localtime originally... maybe it's not needed at all.
❤️
We use ActiveSupport's time extension. If the zone has been set, such as utc, we'll use that, otherwise, it will use Time.now, which will be local.
jrafanie
force-pushed
the
avoid_rails7_deprecation_ar_base_default_timezone
branch
from
400138d
to
8e374a3
Compare
|
Checked commit jrafanie@8e374a3 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
| else | ||
| Time.zone.now | ||
| end | ||
| Time.current |
There was a problem hiding this comment.
@agrare this handles if Time.zone is not set (nil) and returns Time.now which should be localtime if not set. If set to utc, it will return utc time via Time.zone.now.
Rails 7 added ActiveRecord.default_timezone and 7.1 will remove it from ActiveRecord::Base.
Extract a memoized method to hide this logic.
Fixes this deprecation in the 7.0 test suite: