-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport changes to the AWS EKS Credentials into the v4.y branch for release #634
Backport changes to the AWS EKS Credentials into the v4.y branch for release #634
Conversation
…e - adds regional support to the method, as well as allowing the kuebclient gem to be used in govcloud Signed-off-by: snorlaX-sleeps <21spock@gmail.com>
Thanks for the nudge @snorlaX-sleeps, I'll backport these commits and get the v4.y branch green on CI and release a v4.12.0 shortly |
Thanks @agrare - I was unsure of the process around backporting, but this was a blocker for the last week or two and it's only when I really went digging that I remembered this was a thing a few years back 🙂 |
@snorlaX-sleeps I've released v4.12.0 including the three PRs that you linked here Let me know if that works for you, thanks! |
Yeah I like to cherry-pick individual merge commits to maintain the commit history and include a changelog and summary in gpg-signed commit and tag. |
There is a failure on windows x truffleruby-head and that test doesn't exist on master which is interesting it went straight to v4.y but it is a setup failure not a code failure, might revert that PR that added the test only to v4.y and backport it properly once the master PR is merged. |
thanks @agrare - I've done a local test with the new gem, with the expected result, will attempt a full build and test tomorrow! |
@agrare - can confirm this is now working for us in both commercial and govcloud AWS accounts. |
Awesome glad to hear it @snorlaX-sleeps |
This PR adds regional support to the method, as well as allowing the kuebclient gem to be used in govcloud
All of this code is available from the main branch and was added in the following PRs:
Without these (old) changes, the currently released gem is unusable.
Some of these changes were added before the v5 cutoff started, but never got released
Fixes: #527
Changes tested in our account - currently patching a copy of this file into our Docker build, overwriting the latest release