-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move util.go to miq-component/utils subpackage #993
base: master
Are you sure you want to change the base?
Conversation
Marking as WIP since I'm not exactly sure how to test this before merging |
e4a66ab
to
f894aa6
Compare
e383502
to
7f9695a
Compare
Checked commit nasark@7f9695a with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Successfully tested this by swapping all |
Nice - Looks good to me. I did expect more "deletes" where copy-pasted methods were switch to using the common methods, or is that a follow up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunne Please review.
This pull request is not mergeable. Please rebase and repush. |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
2 similar comments
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
Currently if util functions are needed elsewhere, the entire
miq-components
package needs to be pulled. It would be nice to be able to pull in just the util methods, this is especially useful for the downstream operator@miq-bot assign @Fryguy
@miq-bot add_reviewer @bdunne
@miq-bot add_labels enhancement, refactoring